[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596538 ]
ASF GitHub Bot logged work on ARTEMIS-3297: ------------------------------------------- Author: ASF GitHub Bot Created on: 14/May/21 07:51 Start Date: 14/May/21 07:51 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632350082 ########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java ########## @@ -668,6 +668,25 @@ Configuration addDiscoveryGroupConfiguration(String key, */ Configuration setJournalDirectory(String dir); + String getJournalHistory(); + + File getJournalHistoryLocation(); + + /** + * Sets the file system directory used to store historical backup journal. + */ + Configuration setJournalHistory(String dir); + + int getJournalHistoryMaxDays(); + + Configuration setJournalHistoryMaxDays(int days); Review comment: This is a neat feature. I think I would call it something else from a configuration perspective. journalRetention or just retention configured with a: int retentionLimit > 0 enum retentionUnit (seconds/days/numFiles) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 596538) Time Spent: 20m (was: 10m) > Historical Backup of Broker Data > -------------------------------- > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature > Affects Versions: 2.17.0 > Reporter: Clebert Suconic > Priority: Major > Fix For: 2.18.0 > > Time Spent: 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)