[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597100 ]
ASF GitHub Bot logged work on ARTEMIS-3297: ------------------------------------------- Author: ASF GitHub Bot Created on: 15/May/21 04:42 Start Date: 15/May/21 04:42 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894507 ########## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ########## @@ -675,6 +675,82 @@ </xsd:annotation> </xsd:element> + <xsd:element name="journal-retention" maxOccurs="1" minOccurs="0"> + <xsd:annotation> + <xsd:documentation> + Configuration about the journal retention configuration. + </xsd:documentation> + </xsd:annotation> + <xsd:complexType> + <xsd:attribute name="unit" use="required"> + <xsd:annotation> + <xsd:documentation> + This configures the period type to use on limit. By default it is DAYS. + </xsd:documentation> + </xsd:annotation> + <xsd:simpleType> + <xsd:restriction base="xsd:string"> + <xsd:enumeration value="DAYS"/> + <xsd:enumeration value="HOURS"/> + <xsd:enumeration value="SECONDS"/> + </xsd:restriction> + </xsd:simpleType> + </xsd:attribute> + <xsd:attribute name="directory" type="xsd:string" use="required"> Review comment: Im one for consistency. Especially as a user mindset. Like why all other dirs the element value yet here its an empty element value but its an attribute. Having things miss match in style makes it harder as you have to cross check everytime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 597100) Time Spent: 9h 40m (was: 9.5h) > Journal Retention Feature > ------------------------- > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature > Affects Versions: 2.17.0 > Reporter: Clebert Suconic > Priority: Major > Fix For: 2.18.0 > > Time Spent: 9h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)