[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=598317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598317
]
ASF GitHub Bot logged work on ARTEMIS-3297:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 22:45
Start Date: 17/May/21 22:45
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r633913845
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -675,6 +675,82 @@
</xsd:annotation>
</xsd:element>
+ <xsd:element name="journal-retention" maxOccurs="1" minOccurs="0">
+ <xsd:annotation>
+ <xsd:documentation>
+ Configuration about the journal retention configuration.
+ </xsd:documentation>
+ </xsd:annotation>
+ <xsd:complexType>
+ <xsd:attribute name="unit" use="required">
+ <xsd:annotation>
+ <xsd:documentation>
+ This configures the period type to use on limit. By
default it is DAYS.
+ </xsd:documentation>
+ </xsd:annotation>
+ <xsd:simpleType>
+ <xsd:restriction base="xsd:string">
+ <xsd:enumeration value="DAYS"/>
+ <xsd:enumeration value="HOURS"/>
+ <xsd:enumeration value="SECONDS"/>
+ </xsd:restriction>
+ </xsd:simpleType>
+ </xsd:attribute>
+ <xsd:attribute name="directory" type="xsd:string"
use="required">
Review comment:
<xsd:element name="journal-retention-directory" maxOccurs="1"
minOccurs="0">
<xsd:annotation>
<xsd:documentation>
the directory to store e journal-retention will take
place.
</xsd:documentation>
</xsd:annotation>
<xsd:complexType>
<xsd:simpleContent>
<xsd:extension base="xsd:string">
<xsd:attribute name="unit" use="optional"
type="timeUnit">
<xsd:annotation>
<xsd:documentation>
This configures the period type to
use on limit. By default it is DAYS.
</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attribute name="period" type="xsd:integer"
use="optional">
<xsd:annotation>
<xsd:documentation>
The amount of time used to keep
files.
</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attribute name="storage-limit"
type="xsd:string" use="optional">
<xsd:annotation>
<xsd:documentation>
Size (in bytes) before we starting
removing files from the retention area.
this is an extra protection on top
of the period.
Notice we first remove files based
on period and if you're using more storage then you
configured we start removing older
files.
By default this is unlimited (not
filled).
Supports byte notation like "K",
"Mb", "GB", etc.
</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
</xsd:extension>
</xsd:simpleContent>
</xsd:complexType>
</xsd:element>
And also define timeUnit so its re-usable going forwards, after all its java
TimeUnit that we use to convert.
<xsd:simpleType name="timeUnit">
<xsd:restriction base="xsd:string">
<xsd:enumeration value="DAYS"/>
<xsd:enumeration value="HOURS"/>
<xsd:enumeration value="MINUTES"/>
<xsd:enumeration value="SECONDS"/>
</xsd:restriction>
</xsd:simpleType>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 598317)
Time Spent: 13h 50m (was: 13h 40m)
> Journal Retention Feature
> -------------------------
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.17.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
