[
https://issues.apache.org/jira/browse/AMQ-7514?focusedWorklogId=620736&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620736
]
ASF GitHub Bot logged work on AMQ-7514:
---------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/21 20:58
Start Date: 08/Jul/21 20:58
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #679:
URL: https://github.com/apache/activemq/pull/679#discussion_r666493721
##########
File path:
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java
##########
@@ -485,15 +490,15 @@ public JmsConnector removeJmsConnector(JmsConnector
connector) {
}
public void masterFailed() {
- if (shutdownOnMasterFailure) {
- LOG.error("The Master has failed ... shutting down");
+ if (shutdownOnActiveFailure) {
+ LOG.error("The Active has failed ... shutting down");
Review comment:
Quickly reading the ticket actually mentions
New terms:
a. For shared storage: ‘active’ and ’standby’
b. For replication: ‘primary’ and ‘replica'
c. For 'white list' and 'blacklist': 'allow list' and 'deny list'
Like wise earlier in the same ticket it mentions
Here are just a few terms that should be changed: * The following terms are
being targeted for change:
'master' and 'slave' should be replaced with the terms 'live' and
'backup''whitelist' and 'blacklist' should be replaced with the terms
'allowlist' and 'denylist'Rename all the git 'master' branches to the term
'main'
A little using terminology within context and avoiding conflicting
terminology is needed here.
I agree i think also we historically overloaded the use of master slave too.
So in this case its the replication one, e.g. the broker is either the
primary instance or the replica instance .. so primary replica should be used
Im also keen we align with Artemis broker for consistency sakes on the way
forward here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 620736)
Time Spent: 3h (was: 2h 50m)
> Replace racially charged terms throughout source code, comments and
> documentation
> ---------------------------------------------------------------------------------
>
> Key: AMQ-7514
> URL: https://issues.apache.org/jira/browse/AMQ-7514
> Project: ActiveMQ
> Issue Type: Task
> Reporter: Bruce Snyder
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Given the racial charged nature of certain terms in today's world, we must
> pull together to create a plan for changing any such terms throughout all the
> ActiveMQ projects and in the git repos themselves.
>
> Example: [https://activemq.apache.org/masterslave.html]
>
> Here are just a few terms that should be changed: * The following terms are
> being targeted for change:
> *
> ** 'master' and 'slave' should be replaced with the terms 'live' and 'backup'
> ** 'whitelist' and 'blacklist' should be replaced with the terms 'allowlist'
> and 'denylist'
> * Rename all the git 'master' branches to the term 'main'
> Proposal notes from activemq-dev mailing list
> Phase 1:
> 1. Deprecate terms such as ‘master’ and ’slave
> 2. log.warn any configuration change notifications
> 3. Provide compatibility under the covers for deprecated terms
> 4. Provide any openwire compatibility changes b/w ActiveMQ 5 and Artemis
> 5. Notify users in an announcement and provide a conversion HOWTO
> Phase 2:
> 1. Remove terminology as part of a major or minor release (SEMVER where ‘y’
> in ‘x.y.z’ is minor version number)
> New terms:
> a. For shared storage: ‘active’ and ’standby’
> b. For replication: ‘primary’ and ‘replica'
> c. For 'white list' and 'blacklist': 'allow list' and 'deny list'
> For example:
> ‘master’ -> ‘active’
> ’slave’ -> ’standby'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
