[ 
https://issues.apache.org/jira/browse/ARTEMIS-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392318#comment-17392318
 ] 

ASF subversion and git services commented on ARTEMIS-3302:
----------------------------------------------------------

Commit 7a9de8eea3fc39ab9ee73b5f30cb6e6b9d79c87d in activemq-artemis's branch 
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7a9de8e ]

ARTEMIS-3302 swap deprecated X509Certificate

Casting the result of getPeerCertificates() to X509Certificate[] mirrors
what is done in the ActiveMQ "Classic" code-base.

A few tests which were imported from ActiveMQ "Classic" to verify our
OpenWire implementation were removed as they relied on a "stub"
implementation of javax.net.ssl.SSLSession that never would have worked
across multiple JDKs once javax.security.cert.X509Certificate[] was
removed. Furthermore, the tests appeared to be related to the OpenWire
*client* and not relevant to our broker-side implementation.


> various use of deprecated-for-removal javax.security.cert.X509Certificate
> -------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3302
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3302
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.17.0
>            Reporter: Robbie Gemmell
>            Priority: Critical
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The codebase is using javax.security.cert.X509Certificate in various places. 
> This was noted superceded by the java.security.cert replacement since ~Java 
> 1.4, and marked deprecated in Java 9 along with the entire 
> javax.security.cert package. The deprecation was raised to for-removal status 
> in Java 13 [1].
> Building using Java 16 [2] without using the -release flag (which doesnt 
> actually work for Artemis due to API usages that -release doesnt permit) 
> means the build uses the Java 16 signatures when compiling regardless what 
> the -target version is, which has the side effect of helpfully pointing out a 
> lot of deprecated-for-removal APIs that the codebase is still using.
> [1] https://bugs.openjdk.java.net/browse/JDK-8160247
> [2] 
> https://github.com/apache/activemq-artemis/runs/2598974966?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to