[
https://issues.apache.org/jira/browse/ARTEMIS-3449?focusedWorklogId=647358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647358
]
ASF GitHub Bot logged work on ARTEMIS-3449:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/21 13:01
Start Date: 07/Sep/21 13:01
Worklog Time Spent: 10m
Work Description: gemmellr commented on pull request #3711:
URL: https://github.com/apache/activemq-artemis/pull/3711#issuecomment-914286613
Even if it visibly isnt called, the remaining strangs seem to suggest like
it should be and presumably was before, so I would leave the existing code for
now and track down why/when it became unused and determine what the actual next
step should be before just removing it, since the getData() usage appears to be
pointing to a potentially significant issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 647358)
Time Spent: 10h 20m (was: 10h 10m)
> Speedup AMQP large message streaming
> ------------------------------------
>
> Key: ARTEMIS-3449
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3449
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> AMQP is using unpooled heap ByteBuffer(s) to stream AMQP large messages:
> given that the underline NIO sequential file can both use FileChannel or
> RandomAccessFile (depending if the ByteBuffer used is direct/heap based),
> both approaches would benefit from using Netty pooled direct buffers and save
> additional copies (performed by RandomAccessFile) to happen, reducing GC too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
