[
https://issues.apache.org/jira/browse/ARTEMIS-3464?focusedWorklogId=649972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649972
]
ASF GitHub Bot logged work on ARTEMIS-3464:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/21 12:22
Start Date: 13/Sep/21 12:22
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3737:
URL: https://github.com/apache/activemq-artemis/pull/3737#discussion_r707281605
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
##########
@@ -153,7 +157,7 @@ public void performScanAck() {
// we should only have a max of 2 scheduled tasks
// one that's might still be currently running, and another one lined up
// no need for more than that
- if (scheduledScanCount.incrementAndGet() < 2) {
+ if (scheduledScanCount.incrementAndGet() <= 2) {
Review comment:
The idea is to have at least 2 scheduled threads...
one that might be running, one that's about to be executed..and I don't see
that logic broken here.
Before with < 2, I would have only up to most 1 thread scheduled.
If I was using a boolean then I agree I would have to get the count before.
I think this is safe here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 649972)
Time Spent: 3h 10m (was: 3h)
> Mirror could Miss Acks with Paging
> ----------------------------------
>
> Key: ARTEMIS-3464
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3464
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.18.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The Mirror target could miss acks in some cases with Paging.
> We should add a scan for when the message couldn't be reached within depaged
> messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
