[
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=717675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717675
]
ASF GitHub Bot logged work on AMQNET-637:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/22 17:26
Start Date: 30/Jan/22 17:26
Worklog Time Spent: 10m
Work Description: Havret commented on a change in pull request #18:
URL:
https://github.com/apache/activemq-nms-openwire/pull/18#discussion_r795217746
##########
File path: src/Transport/ResponseCorrelator.cs
##########
@@ -85,15 +87,40 @@ public override FutureResponse AsyncRequest(Command command)
return future;
}
- public override Response Request(Command command, TimeSpan timeout)
+ public override Task<Response> RequestAsync(Command command, TimeSpan
timeout)
{
+ TaskCompletionSource<Response> taskCompletionSource = new
TaskCompletionSource<Response>(TaskCreationOptions.RunContinuationsAsynchronously);
+ if (timeout.TotalMilliseconds > 0)
+ {
+ CancellationTokenSource ct = new
CancellationTokenSource(timeout);
+ ct.Token.Register(() =>
+ {
+ taskCompletionSource.TrySetException(new
RequestTimedOutException(timeout));
+ }, false);
+ }
+
FutureResponse future = AsyncRequest(command);
- future.ResponseTimeout = timeout;
- Response response = future.Response;
- return response;
+
+ _ = future.Task.ContinueWith(t =>
Review comment:
The logic you are applying here should be applied as part of
`OnCommand`. You basically should resolve promise there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 717675)
Time Spent: 15h 20m (was: 15h 10m)
> NMS 2.0
> -------
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: NMS
> Affects Versions: 1.8.0
> Reporter: Michael Andre Pearce
> Priority: Major
> Fix For: API-2.0.0
>
> Time Spent: 15h 20m
> Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the
> latest JMS 2.0 api
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
