[
https://issues.apache.org/jira/browse/AMQ-8472?focusedWorklogId=725155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725155
]
ASF GitHub Bot logged work on AMQ-8472:
---------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/22 14:10
Start Date: 11/Feb/22 14:10
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #766:
URL: https://github.com/apache/activemq/pull/766#discussion_r804678655
##########
File path: activemq-partition/pom.xml
##########
@@ -92,6 +84,16 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>ch.qos.reload4j</groupId>
+ <artifactId>reload4j</artifactId>
+ <scope>test</scope>
Review comment:
Personally I would be fine with test scope if this still works when used
(by dependants, not within the build tests), but just to note: this is
effectively different than what it did in 5.16.3 before (and different than you
said you were going to do on the JIRA) since the module wont pass on reload4j
like this anymore, wheras log4j was being passed on before due to the zookeeper
related bits that brought it in before (but are now excluded via
dependencyManagement).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 725155)
Time Spent: 6h 10m (was: 6h)
> Switch to reload4j for logging
> ------------------------------
>
> Key: AMQ-8472
> URL: https://issues.apache.org/jira/browse/AMQ-8472
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.16.4
>
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> This task is to switch AMQ 5.16.x to use Reload4J instead of Log4J for
> logging. That way we get fixes for the various CVEs in Log4J 1.x, until AMQ
> picks up Log4J 2.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
