[
https://issues.apache.org/jira/browse/ARTEMIS-3720?focusedWorklogId=741835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741835
]
ASF GitHub Bot logged work on ARTEMIS-3720:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/22 19:51
Start Date: 15/Mar/22 19:51
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3983:
URL: https://github.com/apache/activemq-artemis/pull/3983#discussion_r827355560
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -213,6 +213,8 @@
private static final String MAX_SIZE_BYTES_NODE_NAME = "max-size-bytes";
+ private static final String MAX_MESSAGES_NODE_NAME = "max-messages";
Review comment:
@jbertram ok.. I like that actually.. I had thought about
max-size-message and I thought it wouldn't be a good term because of English
grammar...
although global-max-messages it sounds fine as is I think?
global-max-size-messages wouldn't sound weird?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 741835)
Time Spent: 1h 40m (was: 1.5h)
> Max number of messages as a deciding factor for Paging
> ------------------------------------------------------
>
> Key: ARTEMIS-3720
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3720
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
