[ https://issues.apache.org/jira/browse/ARTEMIS-3757?focusedWorklogId=752764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752764 ]
ASF GitHub Bot logged work on ARTEMIS-3757: ------------------------------------------- Author: ASF GitHub Bot Created on: 05/Apr/22 11:26 Start Date: 05/Apr/22 11:26 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4011: URL: https://github.com/apache/activemq-artemis/pull/4011#discussion_r842674425 ########## artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java: ########## @@ -708,6 +720,149 @@ public void testValuePostFixModifier() throws Throwable { Assert.assertEquals(25 * 1024, configuration.getGlobalMaxSize()); } + @Test + public void testSystemPropValueReplaced() throws Exception { + ConfigurationImpl configuration = new ConfigurationImpl(); + Properties properties = new Properties(); + final String homeFromDefault = "default-home"; + final String homeFromEnv = System.getenv("HOME"); + properties.put("name", "${HOME:" + homeFromDefault + "}"); + configuration.parsePrefixedProperties(properties, null); + if (homeFromEnv != null) { + Assert.assertEquals(homeFromEnv, configuration.getName()); + } else { Review Comment: true, but it also exercise the default value in that case. Issue Time Tracking ------------------- Worklog Id: (was: 752764) Time Spent: 0.5h (was: 20m) > properties config - allow system and env var substitution > --------------------------------------------------------- > > Key: ARTEMIS-3757 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3757 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration > Affects Versions: 2.21.0 > Reporter: Gary Tully > Assignee: Gary Tully > Priority: Major > Fix For: 2.22.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > It would be useful if the key/value pairs from properties files supported > substitution of env vars, from system properties with fallback to the os.env. > There is support in the xml config for system props -- This message was sent by Atlassian Jira (v8.20.1#820001)