[ 
https://issues.apache.org/jira/browse/ARTEMIS-3756?focusedWorklogId=754083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754083
 ]

ASF GitHub Bot logged work on ARTEMIS-3756:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Apr/22 13:45
            Start Date: 07/Apr/22 13:45
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4009:
URL: https://github.com/apache/activemq-artemis/pull/4009#discussion_r845154841


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -425,10 +425,10 @@
            format = Message.Format.MESSAGE_FORMAT)
    void broadcastTimeout(int retry, int maxretry);
 
-   @LogMessage(level = Logger.Level.WARN)
-   @Message(id = 212078, value = "Connection factory parameter ignored {0}",
-      format = Message.Format.MESSAGE_FORMAT)
-   void connectionFactoryParameterIgnored(String parameterName);

Review Comment:
   Can you just remove this, and call logger.debug directly where this is being 
called.
   
   We always use logger.debug at the logger on the class.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 754083)
    Time Spent: 20m  (was: 10m)

> Connectors extra parameters are not passed throught the URI
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-3756
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3756
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.21.0
>            Reporter: Emmanuel Hugonnet
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Since the connectors extra parameters are not passed through the URI when 
> obtaining a  ConnectionFactory by JNDI it won't be using them. This may be an 
> issue for any SPI on the client side since it doesn't get the configuration 
> defined on the server side.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to