[
https://issues.apache.org/jira/browse/ARTEMIS-3707?focusedWorklogId=757236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757236
]
ASF GitHub Bot logged work on ARTEMIS-3707:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/22 22:20
Start Date: 14/Apr/22 22:20
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #3999:
URL:
https://github.com/apache/activemq-artemis/pull/3999#issuecomment-1099675775
I did read the JIRA before reviewing, as I said that aspect wasnt (still
isnt) clear to me, in part as I simply dont use these bits, but mainly due to
the PR essentially contradicting itself with adding documentation saying you
"must" build your own and another example doing that.
I dont think this is dead in the slightest. I do think there was a bunch of
previous feedback you hadnt yet actioned (until perhaps now) even when
repeated, or actually possibly still havent in the case of getting rid of the
merge commits and squashing your changes to minimise the (now-getting-silly)
number of commits, and rebasing things against the current main.
I havent had a chance to look at what you have now added since my previous
comments yet, I will take another look when back from vacation next week.
Issue Time Tracking
-------------------
Worklog Id: (was: 757236)
Time Spent: 5.5h (was: 5h 20m)
> ResourceAdapter improvements
> ----------------------------
>
> Key: ARTEMIS-3707
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3707
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Waldi
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Hi Everybody,
> I've tried to install the resourceAdapter in openliberty/WLP by myself. I've
> got in some troubles and fixed it by myself. Now, I would like to provide the
> modifications and a small piece of documentation of the resourceAdapter, if
> interested.
> * Sample config / project for openliberty/WLP
> * remove usage of the transactionManager in the resource adapter
> * fix the jakarta ra.xml namespaces and classnames
> * create a maven build for a rar archive with fewer dependencies and
> therefore a smaller footprint.
> I took notice of ARTEMIS-1487 and ARTEMIS-1614. In my opinion, with my
> contributions, we can close these issues. Can you tell me your thoughts and
> give me feedback?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
