[
https://issues.apache.org/jira/browse/ARTEMIS-3759?focusedWorklogId=765902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765902
]
ASF GitHub Bot logged work on ARTEMIS-3759:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/22 09:44
Start Date: 04/May/22 09:44
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4054:
URL: https://github.com/apache/activemq-artemis/pull/4054#discussion_r864642643
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -208,6 +232,13 @@ public void sendMessage(Message message, RoutingContext
context, List<MessageRef
return;
}
+ if (ignoreAddress(context.getAddress(message))) {
+ if (logger.isTraceEnabled()) {
+ logger.trace("server " + server + " is discarding send to excluded
address");
Review Comment:
In addition to the "excluded" comment, for this one I'd also note it should
say _which address_ is in play otherwise its not very helpful.
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -162,6 +172,12 @@ public void createQueue(QueueConfiguration
queueConfiguration) throws Exception
}
return;
}
+ if (ignoreAddress(queueConfiguration.getAddress())) {
+ if (logger.isTraceEnabled()) {
+ logger.trace("Skipping create " + queueConfiguration + ", queue
address" + queueConfiguration.getAddress() + " is excluded");
Review Comment:
Given the filter does actually have 'exclusions' and it might not actually
be excluded, so much as just not-included, I would reword this to avoid saying
it is 'excluded' specifically, but instead something more general like 'doesnt
match filter'.
Issue Time Tracking
-------------------
Worklog Id: (was: 765902)
Time Spent: 2h 40m (was: 2.5h)
> Allow for Mirroring (Broker Connections) to specify a specific set of
> addresses to send events, as is done for a cluster connection
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3759
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3759
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.19.1, 2.21.0
> Reporter: Mikhail Lukyanov
> Priority: Major
> Attachments: ImageAddressSyntax.png, ImageInternalQueues.png
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> If a target broker of mirroring is in a cluster, then mirroring of the
> broker's internal queues also occurs, and often messages accumulate in such
> queues. In theory, internal cluster queues should not be mirrored, this does
> not make much sense.
> Therefore, it would be convenient to allow you to configure for which
> addresses and their queues mirroring will be performed, events will be sent
> (message-acknowledgements, queue-removal, queue-creation). The syntax that is
> used to specify the *_addresses_* of the *_cluster connection_* is well
> suited for this.
> Mirrored internal cluster queues
> !ImageInternalQueues.png!
> Address syntax
> !ImageAddressSyntax.png!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
