[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=779259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779259
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 20:58
Start Date: 07/Jun/22 20:58
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r891704311
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java:
##########
@@ -1444,20 +1276,39 @@ public List<MessageReference>
getRelatedMessageReferences() {
private class CursorIterator implements PageIterator {
- private PagePositionAndFileOffset position = null;
+ // The cursorLogger is declared as static on the class, just to avoid a
getLogger() call every time
+ private final Logger logger = cursorLogger;
Review Comment:
I would get this compilation error if I declared it static final:
Static declarations in inner classes are not supported at language level '11'
I wanted to use a different logger for the inner class...
but I will now just use the top logger, it's for tracing only anyways
Issue Time Tracking
-------------------
Worklog Id: (was: 779259)
Time Spent: 2h 50m (was: 2h 40m)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.24.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
