[jira] [Work logged] (ARTEMIS-3875) expose more consumer/producer metrics

[ASF GitHub Bot (Jira)]

Title: Message Title

ASF GitHub Bot added a worklog on ARTEMIS-3875   gemmellr commented on code in PR #4126: URL: https://github.com/apache/activemq-artemis/pull/4126#discussion_r910028571 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java: ########## @@ -58,6 +60,16 @@ public JsonObjectBuilder toJson(ServerConsumer consumer) { consumerClientID = session.getMetaData(ClientSession.JMS_SESSION_CLIENT_ID_PROPERTY); } + List<MessageReference> deliveringMessages = consumer.getDeliveringMessages(); + long deliveringMessageSize = 0; + for (int i = 0; i < deliveringMessages.size(); i++) { + MessageReference messageReference = deliveringMessages.get(i); + deliveringMessageSize += messageReference.getMessage().getEncodeSize(); + } + long currentTime = System.currentTimeMillis(); + long lastDeliveredTimeElapsed = consumer.getLastDeliveredTime() == 0 ? 0 : currentTime - consumer.getLastDeliveredTime(); + long lastAckTimeElapsed = consumer.getLastAcknowledgedTime() == 0 ? 0 : currentTime - consumer.getLastAcknowledgedTime(); Review Comment: Seems familiar..more scope for sharing impl? ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java: ########## @@ -111,6 +128,27 @@ public Object getField(ServerConsumer consumer, String fieldName) { return consumer.getConnectionRemoteAddress(); case CREATION_TIME: return new Date(consumer.getCreationTime()); + case DELIVERING_COUNT: + return consumer.getDeliveringMessages().size(); + case DELIVERING_SIZE: + List<MessageReference> deliveringMessages = consumer.getDeliveringMessages(); + long deliveringMessageSize = 0; + for (int i = 0; i < deliveringMessages.size(); i++) { + MessageReference messageReference = deliveringMessages.get(i); + deliveringMessageSize += messageReference.getMessage().getEncodeSize(); + } + return deliveringMessageSize; + case MESSAGES_ACKNOWLEDGED: + return consumer.getMessagesAcknowledged(); + case LAST_DELIVERED_TIME_ELAPSED: { + long currentTime = System.nanoTime(); + return consumer.getLastDeliveredTime() == 0 ? 0 : currentTime - consumer.getLastDeliveredTime(); + } + case LAST_ACKNOWLEDGED_TIME_ELAPSED: { + long currentTime = System.nanoTime(); + return consumer.getLastAcknowledgedTime() == 0 ? 0 : currentTime - consumer.getLastAcknowledgedTime(); Review Comment: Ditto Worklog entry: 10m logged by ASF GitHub Bot Change By: ASF GitHub Bot Time Spent: 50m 1h Add Comment   This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)