[
https://issues.apache.org/jira/browse/ARTEMIS-3139?focusedWorklogId=786623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786623
]
ASF GitHub Bot logged work on ARTEMIS-3139:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/22 14:38
Start Date: 30/Jun/22 14:38
Worklog Time Spent: 10m
Work Description: ryan-highley commented on code in PR #4122:
URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911106800
##########
artemis-server/src/test/resources/ConfigurationTest-xinclude-config-acceptors.xml:
##########
@@ -14,7 +14,10 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-<acceptors xmlns="urn:activemq:core">
+<acceptors xmlns="urn:activemq:core"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="urn:activemq:core
../../../../artemis-server/src/main/resources/schema/artemis-configuration.xsd"
Review Comment:
Correct, none of these test files need to be so explicit. The
{{broker-connections}} file element covers the original include namespace
attribute test case matching the documentation.
I added the common namespace attribute combinations to the existing xinclude
element test files to ensure adequate testing of includes with the updated XSD.
This file and the {{address-settings}} include explicitly define the schema
definition location, just as {{ConfigurationTest-xinclude-config.xml}} does, as
well as an explicit type reference attribute. The {{addresses}} file skips the
explicit type reference. The {{broker-connections}} file include sticks with
the original, bare {{xmlns}} URN.
Issue Time Tracking
-------------------
Worklog Id: (was: 786623)
Time Spent: 2h (was: 1h 50m)
> Anonymous types in artemis-configuration.xsd
> --------------------------------------------
>
> Key: ARTEMIS-3139
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3139
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Tuve Nordius
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The artemis-configuration.xsd has a lot of anonymous types which makes it
> hard to create a modulirized configuration. If I want to have diverts in a
> seperate file I can do that but I cant get any validation/ help for any
> editor.
> example:
> I can do in an included file diverts.xml something like
> {code:java}
> <diverts xmlns="urn:activemq:core">{code}
> I would like to do like bellow, but I can't since divertsType does not exist
> other as an inline anonymous type.
>
> {code:java}
> <diverts xmlns="urn:activemq:core"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="urn:activemq:core
> /schema/artemis-configuration.xsd"
> xsi:type="divertsType" >
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
