[
https://issues.apache.org/jira/browse/ARTEMIS-3139?focusedWorklogId=786709&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786709
]
ASF GitHub Bot logged work on ARTEMIS-3139:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/22 16:36
Start Date: 30/Jun/22 16:36
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on code in PR #4122:
URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911224533
##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -16,18 +16,23 @@
limitations under the License.
Review Comment:
As i said, if theres a specific, area that needs to change (e.g. a
particular section isn't importable but is sensible to extract) great, im happy
to help focus to address the point area, but as it stands and as a project
maintainer (pmc) i don't feel that comfortable with this change the risk is
very large and i don't feel is needed personally. If other maintainers (pmc or
committers) wish to jump in here, and feel very confident about the change not
breaking anyone's setups then great. Though the fact existing configs for tests
is needed to be changed to support the change, suggests this change is a break
change. The change should not require any existing tests or configs to have
change.
Issue Time Tracking
-------------------
Worklog Id: (was: 786709)
Time Spent: 4h 50m (was: 4h 40m)
> Anonymous types in artemis-configuration.xsd
> --------------------------------------------
>
> Key: ARTEMIS-3139
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3139
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Tuve Nordius
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> The artemis-configuration.xsd has a lot of anonymous types which makes it
> hard to create a modulirized configuration. If I want to have diverts in a
> seperate file I can do that but I cant get any validation/ help for any
> editor.
> example:
> I can do in an included file diverts.xml something like
> {code:java}
> <diverts xmlns="urn:activemq:core">{code}
> I would like to do like bellow, but I can't since divertsType does not exist
> other as an inline anonymous type.
>
> {code:java}
> <diverts xmlns="urn:activemq:core"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="urn:activemq:core
> /schema/artemis-configuration.xsd"
> xsi:type="divertsType" >
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
