[ 
https://issues.apache.org/jira/browse/ARTEMIS-4025?focusedWorklogId=816042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-816042
 ]

ASF GitHub Bot logged work on ARTEMIS-4025:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/22 09:10
            Start Date: 12/Oct/22 09:10
    Worklog Time Spent: 10m 
      Work Description: gtully commented on code in PR #4241:
URL: https://github.com/apache/activemq-artemis/pull/4241#discussion_r993204103


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -611,13 +614,24 @@ public void setProperties(String 
fileUrltoBrokerProperties) {
       propertiesFileUrl = fileUrltoBrokerProperties;
    }
 
+   @Override
+   public String getStatus() {
+      return serverStatus.asJson();
+   }
+
+   @Override
+   public void updateStatus(String component, String statusJson) {
+      serverStatus.update(component, statusJson);
+   }
+
    private void internalStart() throws Exception {
       if (state != SERVER_STATE.STOPPED) {
          logger.debug("Server already started!");
          return;
       }
 
       configuration.parseProperties(propertiesFileUrl);
+      updateStatus("configuration", configuration.getStatus());

Review Comment:
   agree, thanks. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 816042)
    Time Spent: 1h 20m  (was: 1h 10m)

> properties config -  provide error status for invalid properties
> ----------------------------------------------------------------
>
>                 Key: ARTEMIS-4025
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4025
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 2.26.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>             Fix For: 2.27.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> following up on the availability of a [status json|ARTEMIS-4007] - trap any 
> errors from bean util property failure to apply, for any in invalid property. 
> Currently all failures to find setters are silently ignored.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to