[
https://issues.apache.org/jira/browse/ARTEMIS-3875?focusedWorklogId=816068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-816068
]
ASF GitHub Bot logged work on ARTEMIS-3875:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/22 10:06
Start Date: 12/Oct/22 10:06
Worklog Time Spent: 10m
Work Description: andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r993261491
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java:
##########
@@ -3586,6 +4115,14 @@ public void testListConsumers() throws Exception {
Assert.assertNotEquals("localAddress", "",
jsonConsumer.getString("localAddress"));
Assert.assertNotEquals("remoteAddress", "",
jsonConsumer.getString("remoteAddress"));
Assert.assertNotEquals("creationTime", "",
jsonConsumer.getString("creationTime"));
+ Assert.assertNotEquals("messagesInTransit", "",
jsonConsumer.getString("messagesInTransit"));
+ Assert.assertNotEquals("messagesInTransitSize", "",
jsonConsumer.getString("messagesInTransitSize"));
+ Assert.assertNotEquals("messageDelivered", "",
jsonConsumer.getString("messageDelivered"));
+ Assert.assertNotEquals("messagesDeliveredSize", "",
jsonConsumer.getString("messagesDeliveredSize"));
+ Assert.assertNotEquals("messagesAcknowledged", "",
jsonConsumer.getString("messagesAcknowledged"));
+ Assert.assertNotEquals("lastDeliveredTimeElapsed", "",
jsonConsumer.getString("lastDeliveredTimeElapsed"));
+ Assert.assertNotEquals("lastAcknowledgedTimeElapsed", "",
jsonConsumer.getString("lastAcknowledgedTimeElapsed"));
Review Comment:
fixed
Issue Time Tracking
-------------------
Worklog Id: (was: 816068)
Time Spent: 3h 40m (was: 3.5h)
> Improve consumer/producer metrics
> ---------------------------------
>
> Key: ARTEMIS-3875
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3875
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> adding the following metrics:
>
> for the Consumer and the methods listAllConsumersAsJSON on server and queue
> mbeans:
> messagesInTransit - number of Messages out for delivery which have not yet
> been acknowledged
> messagesInTransitSize - The total size of Messages out for delivery which
> have not yet been acknowledged
> messagesDelivered - Number of messages delivered
> messagesDeliveredSize' - total size of messages delivered
> messagesAcknowledged - total number of Messages Acknowledged
> messagesAcknowledgedAwaitingCommit - Total number of messages in a
> transaction that are acknowledged but awaiting a commit
> lastDeliveredTime - The time in milliseconds of the last message delivered
> lastAcknowledgedTime - The time in milliseconds of the last message
> acknowledged
>
> for the Producer add to the listProducers and listproducersasJSON mbean
> methods
> msgSent - The number of messages sent by a producer
> msgSizeSent - The total size of messages sent by a producer
> lastUUIDSent - The UUID of the last message sent
>
> The producer views are currently quite broken, different protocols show
> different producer info and number of producers, this is because in core we
> add a single producer per session which means you get 2 for ecey core
> session. Im changing this to be a producer for every address sent to. For
> normal producers this will now show s single producer for every protocol, for
> anon producers this will show a producer for every address sent to. For DOS
> protection this will max on 100 producers and they will also be torn down
> when the session is closed.
>
> Ive also move the use of targetAddressInfos into the server producer for
> consistencey.
>
> Other improvements
> * Consolidate the names used by the different methods to be more consistent
> and referenced by static variables.
> * use statics in all the tests
> * add tests for different message count scenarios
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
