[
https://issues.apache.org/jira/browse/AMQ-9153?focusedWorklogId=822307&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822307
]
ASF GitHub Bot logged work on AMQ-9153:
---------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/22 13:33
Start Date: 01/Nov/22 13:33
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #927:
URL: https://github.com/apache/activemq/pull/927#discussion_r1010435045
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -2210,6 +2210,16 @@ private PendingList doActualDispatch(PendingList list)
throws Exception {
// no further dispatch of list to a full consumer to
// avoid out of order message receipt
fullConsumers.add(s);
+
+ //For full consumers we need to mark that they are
slow and
+ // then call the broker.slowConsumer() hook if
implemented
+ if (s instanceof PrefetchSubscription) {
Review Comment:
You can't really add that check here because that the callback could be used
for many different things. Advisories is just one use case and implementation.
Issue Time Tracking
-------------------
Worklog Id: (was: 822307)
Time Spent: 1h 20m (was: 1h 10m)
> Fix Slow Consumer Advisory for Queue subscriptions
> --------------------------------------------------
>
> Key: AMQ-9153
> URL: https://issues.apache.org/jira/browse/AMQ-9153
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 5.17.2
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 5.18.0, 5.17.3
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The {{AdvisoryTests}} class was not running due to a bug with the the test
> configuration that is now fixed in AMQ-9152. The {{testSlowConsumerAdvisory}}
> test is now failing when run so this needs to be investigated to see if it's
> a real failure and something broke or if the test needs to be fixed.
> After further investigation it turns out after changse in AMQ-1902 it no
> longer works at all for queues (only durables and topic subs) so it needs to
> be fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
