[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822383
]
ASF GitHub Bot logged work on ARTEMIS-4020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/22 16:07
Start Date: 01/Nov/22 16:07
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r1010614085
##########
artemis-cli/src/test/resources/toUpgradeTest/etc/artemis.profile:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARTEMIS_HOME='/Users/someUser/Downloads/upgrade/apache-artemis-2.25.0'
+ARTEMIS_INSTANCE='/Users/someUser/Downloads/toUpgradeTest'
+ARTEMIS_DATA_DIR='/Users/someUser/Downloads/toUpgradeTest/data'
+ARTEMIS_ETC_DIR='/Users/someUser/Downloads/toUpgradeTest/etc'
+ARTEMIS_OOME_DUMP='/Users/someUser/Downloads/toUpgradeTest/log/oom_dump.hprof'
Review Comment:
I think it would be better to try having the test files reflect the actual
path. We know what it should be, so should be able to e.g filter the resources
to substituate it in.
##########
artemis-cli/src/test/resources/toUpgradeTest/etc/artemis.profile:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARTEMIS_HOME='/Users/someUser/Downloads/upgrade/apache-artemis-2.25.0'
+ARTEMIS_INSTANCE='/Users/someUser/Downloads/toUpgradeTest'
+ARTEMIS_DATA_DIR='/Users/someUser/Downloads/toUpgradeTest/data'
+ARTEMIS_ETC_DIR='/Users/someUser/Downloads/toUpgradeTest/etc'
+ARTEMIS_OOME_DUMP='/Users/someUser/Downloads/toUpgradeTest/log/oom_dump.hprof'
Review Comment:
I think it would be better to try having the test files reflect the actual
path. We know what it should be, so should be able to e.g filter the resources
to substitute it in.
Issue Time Tracking
-------------------
Worklog Id: (was: 822383)
Time Spent: 15.5h (was: 15h 20m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 15.5h
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For the broker, the assembly distribution will include [Log4J
> 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging
> implentation, with the "artemis create" CLI command used to create broker
> instances now creating a log4j2.properties configuration within the
> <broker-instance>/etc/ directory to configure Log4J. Details for upgrading an
> existing broker-instance is given in (/will be, once the release is out) the
> [version upgrade
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
