[
https://issues.apache.org/jira/browse/AMQ-9161?focusedWorklogId=826097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826097
]
ASF GitHub Bot logged work on AMQ-9161:
---------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/22 11:08
Start Date: 15/Nov/22 11:08
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #931:
URL: https://github.com/apache/activemq/pull/931#issuecomment-1315154532
If you are deprecating one type of JDBC support but keeping another type of
support, the JIRA really doesnt make that clear...it just reads like [eventual]
total removal of JDBC support.
Its not clear to the classes need relocated in order to deprecate the
journal, particularly when the main @Deprecated(forRemoval = true) additions
are only in the classes already in the tree? (Might be nice if the deprecations
noted to use the other stuff instead, if that is the intent).
Changing system properties seems like a breaking change of sorts, which
seems a bit weird do while only keeping this unmaintained stuff around in the
first place to support any existing users, and then only to remove it later. So
its still there if people want it, but doesnt necessarily behave like it did
when used previously, which may or may not be immediately obvious to them?
Seems a bit off.
I'd probably go a different route and either just remove it now, or leave it
essentially as-is but deprecated for removal and maybe logging a warning or
error message if used to note its going away and when...then later either again
simply remove it, or first critically disable it with an exception indicating
its done for but noting e.g a sys prop to turn it back on for one final chance
to move off it. A deprecation + logging style change could also be backported
to 5.17.x to get the ball rolling.
Issue Time Tracking
-------------------
Worklog Id: (was: 826097)
Time Spent: 1h 10m (was: 1h)
> Relocate activeio classes to activemq-jdbc-store and deprecate JDBC Journal
> ---------------------------------------------------------------------------
>
> Key: AMQ-9161
> URL: https://issues.apache.org/jira/browse/AMQ-9161
> Project: ActiveMQ
> Issue Type: Task
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Major
> Fix For: 5.18.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The activeio dependency is very dated. Currently, the only module using any
> classes is the activemq-jdbc-store.
> This JIRA will relocate the activeio classes to the jdbc module and remove
> the activeio dependency.
> The intent of this changes is to take a step forward towards eventual removal
> of the JDBC Journal. This approach is lieu of an activeio upgrade + release
> so we can make the breaking change (remove activeio and deprecate JDBC
> Journal) in 5.18.0 and then complete the removal in 5.18.x point release or
> 5.19.x.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
