[ 
https://issues.apache.org/jira/browse/AMQ-8354?focusedWorklogId=838924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838924
 ]

ASF GitHub Bot logged work on AMQ-8354:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jan/23 18:35
            Start Date: 12/Jan/23 18:35
    Worklog Time Spent: 10m 
      Work Description: NikitaShupletsov commented on code in PR #953:
URL: https://github.com/apache/activemq/pull/953#discussion_r1068483608


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -2387,8 +2495,8 @@ private QueueMessageReference 
getMatchingMessage(MessageDispatchNotification mes
                     messages.reset();
                     while (messages.hasNext()) {
                         MessageReference node = messages.next();
-                        messages.remove();

Review Comment:
   The idea of this change is to delete only the message that we are looking 
for. Because deleting all messages up to the one we need prevents reading them 
in future. Basically if we delete them here, we will not be able to get them 
anymore. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 838924)
    Time Spent: 1.5h  (was: 1h 20m)

> Asynchronous Disaster Recovery
> ------------------------------
>
>                 Key: AMQ-8354
>                 URL: https://issues.apache.org/jira/browse/AMQ-8354
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: Étienne Hossack
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In ActiveMQ Artemis, asynchronous broker replication can be achieved through 
> an AMQP mirror. This provides a strong solution for disaster recovery.
> We do not have such a feature in the ActiveMQ 5.X codebase, and there is 
> great potential to satisfy compliance needs with such a feature.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to