[ 
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=841574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841574
 ]

ASF GitHub Bot logged work on ARTEMIS-3042:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jan/23 16:05
            Start Date: 25/Jan/23 16:05
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #4297:
URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1086751779


##########
artemis-image/README.md:
##########
@@ -0,0 +1,93 @@
+###What is in the image
+
+An _empty_, _open_ broker with a default acceptor on port 61616
+
+ - by empty: has no addresses or queues but will auto create on demand
+ - by open: has no security; authentication or authorization, users or roles
+
+###How will the image behave
+
+ 1) the image will use or create `/app/data` for persistence of data
+
+ 2) the image will use any [.properties 
files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties)
 from `/app/etc` to augment configuration
+
+ 3) the image will use `/app/etc/broker.xml` if present, to bootstrap 
configuration, the 'bring your own config' use case
+
+###Build and Use
+
+First build an OCI image tar file from this artemis project using mvn:
+
+ `$> mvn install`
+
+An OCI image is created as a tar file, that tar can be loaded into a registry, 
eg:
+
+ `$> podman image load --input target/jib-image.tar`
+
+To run the image with host network access, localhost:61616 will be visible, 
use:
+
+ `$> podman run --net=host localhost/target/activemq-artemis-image:<...>`

Review Comment:
   Is there a "so" missing in ", localhost:61616 will be visible,"?
   
   Or why not just show mapping port(s) specifically, as most examples 
typically tend to? I see some issues suggesting --net=host doesnt work on all 
OS.
   
   Expanding/hinting on whats expected to be in the "\<...\>" might be useful 
to some folks...



##########
artemis-image/README.md:
##########
@@ -0,0 +1,93 @@
+###What is in the image
+
+An _empty_, _open_ broker with a default acceptor on port 61616
+
+ - by empty: has no addresses or queues but will auto create on demand
+ - by open: has no security; authentication or authorization, users or roles
+
+###How will the image behave
+
+ 1) the image will use or create `/app/data` for persistence of data
+
+ 2) the image will use any [.properties 
files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties)
 from `/app/etc` to augment configuration

Review Comment:
   Should it be more specific? E.g what if you want to tweak the logging 
configuration .properties, where does that file go? Etc seems obvious..



##########
artemis-image/README.md:
##########
@@ -0,0 +1,97 @@
+###What is in the image
+
+An _empty_, _open_ broker with a default acceptor on port 61616

Review Comment:
   Why not the usual default set, with other e.g IANA registered ports?



##########
artemis-image/pom.xml:
##########
@@ -0,0 +1,127 @@
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements. See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License. You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+   <modelVersion>4.0.0</modelVersion>
+
+   <parent>
+      <groupId>org.apache.activemq</groupId>
+      <artifactId>artemis-pom</artifactId>
+      <version>2.28.0-SNAPSHOT</version>
+   </parent>
+
+   <artifactId>artemis-image</artifactId>
+   <name>Apache ActiveMQ Artemis Image</name>
+
+   <properties>
+      <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 841574)
    Time Spent: 3h 40m  (was: 3.5h)

> Official Docker Multistage Build as well as an official Docker image.
> ---------------------------------------------------------------------
>
>                 Key: ARTEMIS-3042
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: John Behm
>            Priority: Minor
>              Labels: docker,, dockerfile,, kubernetes
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to 
> build or to setup Docker image that automatically builds the project from 
> source, discards the build container and moves the necessary files over to 
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at 
> all.
>  
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is  very 
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so 
> complex, one will not be able to do this within one month without having gone 
> through the whole documentation multiple times.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to