[
https://issues.apache.org/jira/browse/ARTEMIS-4175?focusedWorklogId=846735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-846735
]
ASF GitHub Bot logged work on ARTEMIS-4175:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/23 21:50
Start Date: 21/Feb/23 21:50
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4375:
URL: https://github.com/apache/activemq-artemis/pull/4375#discussion_r1113604153
##########
tests/leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/ClientLeakTest.java:
##########
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.leak;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.Destination;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TextMessage;
+import java.lang.invoke.MethodHandles;
+import java.util.HashMap;
+
+import io.github.checkleak.core.CheckLeak;
+import org.apache.activemq.artemis.api.core.TransportConfiguration;
+import org.apache.activemq.artemis.core.config.impl.ConfigurationImpl;
+import
org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.ActiveMQServers;
+import org.apache.activemq.artemis.core.server.Queue;
+import org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl;
+import org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl;
+import org.apache.activemq.artemis.core.server.impl.ServerStatus;
+import org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.Wait;
+import org.apache.qpid.proton.engine.impl.DeliveryImpl;
+import org.apache.qpid.proton.engine.impl.ReceiverImpl;
+import org.apache.qpid.proton.engine.impl.SenderImpl;
+import org.apache.qpid.proton.engine.impl.SessionImpl;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Assume;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.activemq.artemis.tests.leak.MemoryAssertions.assertMemory;
+import static
org.apache.activemq.artemis.tests.leak.MemoryAssertions.basicMemoryAsserts;
+
+// This test spawns the server as a separate VM
+// as we need to count exclusively client objects from qpid-proton
+public class ClientLeakTest extends ActiveMQTestBase {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ private static final String LEAK_SERVER = "LEAK-SERVER-STARTED";
+
+ public static void main(String arg[]) {
+
+ try {
+ ConfigurationImpl configuration = new
ConfigurationImpl().setSecurityEnabled(false).setJournalMinFiles(2).setJournalFileSize(100
*
1024).setJournalType(getDefaultJournalType()).setJournalDirectory("./data/journal").setBindingsDirectory("./data/binding").setPagingDirectory("./data/page").setLargeMessagesDirectory("./data/lm").setJournalCompactMinFiles(0).setJournalCompactPercentage(0).setClusterPassword(CLUSTER_PASSWORD).setJournalDatasync(false);
+ configuration.addAcceptorConfiguration(new
TransportConfiguration(NETTY_ACCEPTOR_FACTORY, new HashMap<String, Object>(),
"netty", new HashMap<String, Object>()));
+ ActiveMQServer server =
ActiveMQServers.newActiveMQServer(configuration, false);
+ server.start();
+ System.out.println(LEAK_SERVER);
+ } catch (Throwable e) {
+ e.printStackTrace();
+ System.exit(-1);
+ }
+
+ }
+
+ @BeforeClass
+ public static void beforeClass() throws Exception {
+ Assume.assumeTrue(CheckLeak.isLoaded());
+ }
+
+ Process serverProcess;
+
+ @Override
+ @Before
+ public void setUp() throws Exception {
+ serverProcess = SpawnedVMSupport.spawnVM(ClientLeakTest.class.getName());
+ runAfter(serverProcess::destroyForcibly);
+
+ boolean success = false;
+ long time = System.currentTimeMillis() + 5_000;
+
+ // this loop will keep trying a connection until the serer has started
+ do {
+ try {
+ ConnectionFactory cf = CFUtil.createConnectionFactory("AMQP",
"tcp://localhost:61616");
+ try (Connection connection = cf.createConnection()) {
+ success = true;
+ }
+ } catch (Throwable e) {
+ logger.debug(e.getMessage(), e);
+ Thread.sleep(100);
+ }
+
+ } while (success == false && System.currentTimeMillis() < time);
+ Assert.assertTrue(success);
+ }
+
+ @After
+ public void stopServer() throws Exception {
+ serverProcess.destroyForcibly();
+ }
+
+ @Test
+ public void testAMQP() throws Exception {
+ final String protocol = "AMQP";
+ CheckLeak checkLeak = new CheckLeak();
+ int REPEATS = 100;
+ int MESSAGES = 20;
+ basicMemoryAsserts();
+
+ ConnectionFactory cf = CFUtil.createConnectionFactory(protocol,
"tcp://localhost:61616");
+
+ try (Connection producerConnection = cf.createConnection(); Connection
consumerConnection = cf.createConnection()) {
+
+ Session producerSession = producerConnection.createSession(true,
Session.SESSION_TRANSACTED);
+
+ Session consumerSession = consumerConnection.createSession(true,
Session.SESSION_TRANSACTED);
+ consumerConnection.start();
+ assertMemory(checkLeak, 0, ReceiverImpl.class.getName());
+
+ for (int i = 0; i < REPEATS; i++) {
+
System.out.println("********************************************************************************");
+ {
+ Destination source = producerSession.createQueue("source");
+ try (MessageProducer sourceProducer =
producerSession.createProducer(source)) {
+ for (int msg = 0; msg < MESSAGES; msg++) {
+ Message message =
producerSession.createTextMessage("hello " + msg);
+ message.setIntProperty("i", msg);
+ sourceProducer.send(message);
+ }
+ sourceProducer.close();
+ producerSession.commit();
+ }
+ }
+
+ // it shouldn't have any sender connects still. The retry loop is
leaving a few behind.:w
+ assertMemory(checkLeak, 5, SenderImpl.class.getName());
Review Comment:
false alarm... I had a producer I forgot to close. duh
Issue Time Tracking
-------------------
Worklog Id: (was: 846735)
Time Spent: 40m (was: 0.5h)
> JournalFileImpl Leaking
> -----------------------
>
> Key: ARTEMIS-4175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4175
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.29.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is another win from Check-Leak / leak-tests
> JournalFileImpl is currently leaking from negative counts.
> Once a file is gone (from reusing or delete), the file negatives are never
> removed.
> This will make a linked list as the negatives will have negatives and they
> will never be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
