[ https://issues.apache.org/jira/browse/ARTEMIS-4206?focusedWorklogId=855239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855239 ]
ASF GitHub Bot logged work on ARTEMIS-4206: ------------------------------------------- Author: ASF GitHub Bot Created on: 06/Apr/23 09:36 Start Date: 06/Apr/23 09:36 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4418: URL: https://github.com/apache/activemq-artemis/pull/4418#issuecomment-1498768874 > I can squash 2 commits in one for two different and related issues. I thought it was better to keep separated. No, lets not squash 'different changes' into one commit (yes I saw, its too late), lets keep different changes separate. In that spirit, the original comment was around lets also try not to make different changes entirely reliant on each other anyway by intertwining and overlapping their multiple commits, such that you cant very simply pick or see the effect of one of the different changes in isolation because the commits were mixed together rather than sequential while adding. Aside, on the squashed commit log message, it starts telling you how to enable the ref counting debug, and then also ends telling you how to enable the ref counting debug but in a less clear way. Seems like one of them could go. Issue Time Tracking ------------------- Worklog Id: (was: 855239) Time Spent: 6h (was: 5h 50m) > Unreferenced AMQP Large Messages are not removed > ------------------------------------------------ > > Key: ARTEMIS-4206 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4206 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: Clebert Suconic > Assignee: Clebert Suconic > Priority: Major > Fix For: 2.29.0 > > Time Spent: 6h > Remaining Estimate: 0h > > Say you crashed the server after the ack, and before the file.remove, and the > journal. record removal. > The AMQP Large Message may not be removed right away, requiring a restart of > the broker. > At this point this is really caused by ARTEMIS-4193 and only affected 2.29.0 > and no previous versions -- This message was sent by Atlassian Jira (v8.20.10#820010)