[
https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=856141&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856141
]
ASF GitHub Bot logged work on ARTEMIS-4171:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/23 14:16
Start Date: 11/Apr/23 14:16
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4430:
URL: https://github.com/apache/activemq-artemis/pull/4430#discussion_r1162887459
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##########
@@ -1130,14 +1130,16 @@ private void sendContinuations(final int packetSize,
try {
session.send(session.getCurrentTransaction(),
EmbedMessageUtil.extractEmbedded((ICoreMessage) message.toMessage(),
storageManager), false, producers.get(senderID), false);
- } catch (Exception e) {
- message.deleteFile();
- throw e;
} catch (Throwable e) {
-
logger.warn("********************************************************************************");
- logger.warn("Throwable on currentLargeMessage {}",
message.getMessageID(), e);
-
logger.warn("********************************************************************************");
-
+ logger.warn(e.getMessage(), e);
Review Comment:
The code this method is calling looks to throw exceptions in fairly
'typical' situations, e.g security checks, disk usage checks. I think starting
to log a full stacktrace for every one of them, when it specifically didnt
before (presumably as the code calling this method should either handle, or
itself print, them), is likely asking for a lot of new questions. Along the
lines of the more typical 'I suddenly got this new error \<provides non-error
info log message and/or stacktrace\>'.
Issue Time Tracking
-------------------
Worklog Id: (was: 856141)
Time Spent: 1h (was: 50m)
> Potential large message file leak
> ---------------------------------
>
> Key: ARTEMIS-4171
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4171
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> If an exception is thrown during the sending of a large message (e.g. from a
> plugin) the large message file can be orphaned on disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
