[
https://issues.apache.org/jira/browse/ARTEMIS-4245?focusedWorklogId=859466&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859466
]
ASF GitHub Bot logged work on ARTEMIS-4245:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/23 18:29
Start Date: 27/Apr/23 18:29
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4441:
URL: https://github.com/apache/activemq-artemis/pull/4441#discussion_r1179543812
##########
artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java:
##########
@@ -283,6 +298,40 @@ public void simpleSecureServer() throws Exception {
Assert.assertFalse(webServerComponent.isStarted());
}
+
+ @Test
+ public void testSimpleSecureServerWithSniHostCheckEnabled() throws
Exception {
+ testSimpleSecureServerWithSniHostCheck(true);
+ }
+
+ @Test
+ public void testSimpleSecureServerWithSniHostCheckDisabled() throws
Exception {
+ testSimpleSecureServerWithSniHostCheck(false);
+ }
Review Comment:
We could do that instead yes.
Issue Time Tracking
-------------------
Worklog Id: (was: 859466)
Time Spent: 50m (was: 40m)
> Expose web SNI settings
> -----------------------
>
> Key: ARTEMIS-4245
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4245
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Expose sniHostCheck and sniRequired settings in the web config.
> {code:xml}
> <web path="web" rootRedirectLocation="console">
> <binding uri="http://localhost:8161"; sniHostCheck="false"
> sniRequired="false">
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
