[ https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=863120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863120 ]
ASF GitHub Bot logged work on ARTEMIS-4291: ------------------------------------------- Author: ASF GitHub Bot Created on: 31/May/23 18:29 Start Date: 31/May/23 18:29 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4487: URL: https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1570714527 BTW, thanks for the contribution! Issue Time Tracking ------------------- Worklog Id: (was: 863120) Time Spent: 3h (was: 2h 50m) > Some metrics do not have the "broker" tag > ----------------------------------------- > > Key: ARTEMIS-4291 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4291 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 2.28.0 > Reporter: Roelof Naude > Priority: Minor > Time Spent: 3h > Remaining Estimate: 0h > > Some metrics do not have the "broker" tag. The "broker" may not match the > "instance" added by e.g. prometheus, leading to a mismatch. > [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java] > should ideally add "broker" to the common tags, e.g: > {code:java} > meterRegistry.config().commonTags("broker", brokerName);{code} > > [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted > to resolve this. -- This message was sent by Atlassian Jira (v8.20.10#820010)