[ 
https://issues.apache.org/jira/browse/ARTEMIS-4312?focusedWorklogId=865556&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865556
 ]

ASF GitHub Bot logged work on ARTEMIS-4312:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/23 15:18
            Start Date: 14/Jun/23 15:18
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4506:
URL: https://github.com/apache/activemq-artemis/pull/4506#discussion_r1229797434


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java:
##########
@@ -270,6 +270,11 @@ public Message redistribute(final Message message,
          logger.debug("Message {} being copied as {}", message.getMessageID(), 
copyRedistribute.getMessageID());
       }
       copyRedistribute.setAddress(message.getAddress());
+      for (SimpleString property : copyRedistribute.getPropertyNames()) {

Review Comment:
   I will amend your commit with the change.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 865556)
    Time Spent: 40m  (was: 0.5h)

> Duplicates with redistribution and multiple multicast queues on the same 
> address
> --------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-4312
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4312
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.28.0
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Consider a set-up with two brokers clustered together and redistribution 
> enabled and a address with about a dozen multicast subscription queues bound 
> to it. If a consumer of one of those subscriptions goes offline, messages 
> will begin to build up in the queue (as expected). When the consumer comes 
> back online, whatever broker it attaches to first will have messages 
> redistributed from the other broker in the cluster. When this redistribution 
> happens the other multicast queues receive some of those redistributed 
> messages (although not all of them) even though they had already received 
> them previously.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to