[ https://issues.apache.org/jira/browse/ARTEMIS-4338?focusedWorklogId=869379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869379 ]
ASF GitHub Bot logged work on ARTEMIS-4338: ------------------------------------------- Author: ASF GitHub Bot Created on: 05/Jul/23 17:05 Start Date: 05/Jul/23 17:05 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4530: URL: https://github.com/apache/activemq-artemis/pull/4530#discussion_r1253399434 ########## tests/smoke-tests/src/main/resources/servers/audit-logging2/log4j2.properties: ########## @@ -30,6 +30,9 @@ logger.artemis_journal.level=INFO logger.artemis_utils.name=org.apache.activemq.artemis.utils logger.artemis_utils.level=INFO +logger.StompConnection.name=org.apache.activemq.artemis.core.protocol.stomp.StompConnection +logger.StompConnection.level=TRACE + Review Comment: I left this in by mistake. ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java: ########## @@ -582,7 +582,7 @@ public void connectionCreated(final ActiveMQComponent component, public void addConnectionEntry(Connection connection, ConnectionEntry entry) { connections.put(connection.getID(), entry); if (AuditLogger.isResourceLoggingEnabled()) { - AuditLogger.createdConnection(connection.getProtocolConnection().getProtocolName(), connection.getID(), connection.getRemoteAddress()); + AuditLogger.createdConnection(connection.getProtocolConnection() == null ? null : connection.getProtocolConnection().getProtocolName(), connection.getID(), connection.getRemoteAddress()); Review Comment: I agree on both counts. Issue Time Tracking ------------------- Worklog Id: (was: 869379) Time Spent: 1.5h (was: 1h 20m) > STOMP inoperable w/resource audit logging enabled > ------------------------------------------------- > > Key: ARTEMIS-4338 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4338 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: STOMP > Affects Versions: 2.29.0 > Reporter: Otavio Rodolfo Piske > Assignee: Justin Bertram > Priority: Blocker > Attachments: camel-stomp-test-debug-2.28.0.log, > camel-stomp-test-debug-2.29.0.log > > Time Spent: 1.5h > Remaining Estimate: 0h > > Recently we tried upgrading to Artemis 2.29, but when doing so our > integration tests started to fail. No code was changed as part of the upgrade. > With 2.29, the connection seems to fail due to a connection timeout: > > {noformat} > 2023-06-29 07:51:40,739 [Impl$6@b91d8c4)] WARN server > - AMQ222067: Connection failure has been detected: AMQ229014: Did not > receive data from /127.0.0.1:50934 within the 60000ms connection TTL. The > connection will now be closed. [code=CONNECTION_TIMEDOUT]{noformat} > > I wasn't able to determine the problem, so I am attaching the debug logs for > an execution with 2.28 and another with 2.29. -- This message was sent by Atlassian Jira (v8.20.10#820010)