[ https://issues.apache.org/jira/browse/ARTEMIS-4362?focusedWorklogId=870750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870750 ]
ASF GitHub Bot logged work on ARTEMIS-4362: ------------------------------------------- Author: ASF GitHub Bot Created on: 13/Jul/23 09:56 Start Date: 13/Jul/23 09:56 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4552: URL: https://github.com/apache/activemq-artemis/pull/4552#discussion_r1262324419 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java: ########## @@ -179,6 +179,14 @@ public class QueueImpl extends CriticalComponentImpl implements Queue { private volatile boolean queueDestroyed = false; + // Variable to control if we should print a flow controlled message or not. + // Once it was flow controlled, we will stop warning until it's cleared once again + private volatile boolean pageFlowControlled = false; + + private volatile long pageFlowControlledLastLog = 0; + + private static final long PAGE_FLOW_CONTROL_PRINT_INTERVAL = 60_000L; Review Comment: we did the same in classic a while back: https://issues.apache.org/jira/browse/AMQ-6854 but I don't think it is a warn, more like some info. Issue Time Tracking ------------------- Worklog Id: (was: 870750) Time Spent: 1h 10m (was: 1h) > Produce a logger when consumers are holding too many messages not allowing > deposing > ----------------------------------------------------------------------------------- > > Key: ARTEMIS-4362 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4362 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Clebert Suconic > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > We should add a log.warn whenever the system can't read more messages because > consumers are holding too many messages in pending state. -- This message was sent by Atlassian Jira (v8.20.10#820010)