[ 
https://issues.apache.org/jira/browse/ARTEMIS-4355?focusedWorklogId=871846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-871846
 ]

ASF GitHub Bot logged work on ARTEMIS-4355:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jul/23 16:05
            Start Date: 19/Jul/23 16:05
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4545:
URL: https://github.com/apache/activemq-artemis/pull/4545#discussion_r1268296418


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ssl/CoreClientOverOneWaySSLTest.java:
##########
@@ -85,9 +85,9 @@ public static Collection getParameters() {
          {"SunJCE", "JCEKS", false, false},
          {"SUN", "JKS", false, false},
          {"SunJSSE", "PKCS12", false, false},
-         {"JCEKS", null, true, false}, // for compatibility with old 
keyStoreProvider
-         {"JKS", null, true, false},   // for compatibility with old 
keyStoreProvider
-         {"PKCS12", null, true, false} // for compatibility with old 
keyStoreProvider
+         {"JCEKS", null, false, false}, // for compatibility with old 
keyStoreProvider
+         {"JKS", null, false, false},   // for compatibility with old 
keyStoreProvider
+         {"PKCS12", null, false, false} // for compatibility with old 
keyStoreProvider

Review Comment:
   I took a look at the ZooKeeper code. As far as I can tell it's using SLF4J 
as the API (just like the broker), and Logback is the implementation. I think 
you'd be fine to exclude Logback via the `pom.xml`.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 871846)
    Time Spent: 3.5h  (was: 3h 20m)

> Update Сurator to 5.5.0; Zookeeper 3.7.1
> ----------------------------------------
>
>                 Key: ARTEMIS-4355
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4355
>             Project: ActiveMQ Artemis
>          Issue Type: Dependency upgrade
>          Components: clustering
>    Affects Versions: 2.29.0
>            Reporter: Alexey Markevich
>            Priority: Minor
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to