[ https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873561 ]
ASF GitHub Bot logged work on ARTEMIS-4372: ------------------------------------------- Author: ASF GitHub Bot Created on: 28/Jul/23 14:46 Start Date: 28/Jul/23 14:46 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4565: URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1277589970 ########## artemis-distribution/src/main/resources/licenses/bin/LICENSE: ########## @@ -286,6 +286,12 @@ For HdrHistogram: This product bundles HdrHistogram, which is available under the "2-clause BSD" license. For details, see licences/LICENSE-hdrhistogram.txt. +============================================================================== +For JLine: +============================================================================== +This product bundles JLine, which is available under the +"3-clause BSD" license. For details, see licences/LICENSE-jline.txt. Review Comment: Referenced file still needs added. ########## artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Artemis.java: ########## @@ -87,9 +68,29 @@ * Notice that this class should not use any logging as it's part of the bootstrap and using logging here could * disrupt the order of bootstrapping on certain components (e.g. JMX being started from log4j) */ -public class Artemis { +@Command(name = "artemis", description = "ActiveMQ Artemis Command Line") +public class Artemis implements Runnable { + + CommandLine commandLine; + + public CommandLine getCommandLine() { + return commandLine; + } + + public Artemis setCommandLine(CommandLine commandLine) { + this.commandLine = commandLine; + return this; + } + + @Override + public void run() { + // We are running the shell by default. + // if you type ./artemis we will go straight to the shell + Shell.runShell(); + } public static void main(String... args) throws Exception { + System.out.println("Line::" + getNameFromBanner()); Review Comment: Is this a leftover? ########## docs/user-manual/en/using-server.md: ########## @@ -53,6 +53,8 @@ The following highlights some important folders on the distribution: ## Creating a Broker Instance +Before the broker is used, an broker *instance* must be created. Review Comment: an -> a I would put the sentence at the start of the existing paragraph below about broker instances. Issue Time Tracking ------------------- Worklog Id: (was: 873561) Time Spent: 3h 50m (was: 3h 40m) > Move CLI framework to picocli and implement auto-complete > --------------------------------------------------------- > > Key: ARTEMIS-4372 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4372 > Project: ActiveMQ Artemis > Issue Type: New Feature > Reporter: Clebert Suconic > Assignee: Clebert Suconic > Priority: Major > Fix For: 2.31.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)