[ https://issues.apache.org/jira/browse/ARTEMIS-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756191#comment-17756191 ]
Mike Artz edited comment on ARTEMIS-4306 at 8/19/23 2:44 AM: ------------------------------------------------------------- [~jbertram] for the metric names should it have just "cache.gets" or should it be "artemis.authentication.cache.gets". We can still use the CacheMeterBinder abstract class either way. The "artemis.authentication.cache.gets" looks like all the other artemis configs at least. Also the user might find it nicer to group all the authentication metrics together going forward as more metrics are added and then group all the authorization metrics together, whether they are cache or not. If they are all just one thing like for example "SecurityMetrics" then we cant use the {{CacheMeterBinder}} {color:#172b4d}(which is actually fine) but just something to think about.{color} was (Author: JIRAUSER301522): [~jbertram] for the metric names should it have just "cache.gets" or should it be "artemis.authentication.cache.gets". We can still use the CacheMeterBinder abstract class either way. The "artemis.authentication.cache.gets" looks like all the other artemis configs at least. Also the user might find it nicer to group all the authentication metrics together going forward as more metrics are added and then group all the authorization metrics together, whether they are cache or not. IF they are all just one thing like for example "SecurityMetrics" then 1. We cant use the {{CacheMeterBinder}} {color:#172b4d}(which is actually fine) but just something to think about.{color} > Add authn/z metrics > ------------------- > > Key: ARTEMIS-4306 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4306 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Justin Bertram > Priority: Major > > It would be useful to have metrics for authn/z successes and failures as well > as for metrics related to the corresponding caches. > See this discussion on the users mailing list for more details: > https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92 -- This message was sent by Atlassian Jira (v8.20.10#820010)