[
https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878243
]
ASF GitHub Bot logged work on ARTEMIS-4393:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/23 19:11
Start Date: 24/Aug/23 19:11
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4582:
URL:
https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1692266650
> I listed them in jira...
The bullet points you provided in the Jira and here in the PR are _not_ a
use-case. They are simply a summary of what you changed. There is no real
explanation of _why_ the existing code is problematic or _how_ your change
benefits the project. Perhaps those things are obvious to you, but they are not
obvious to me and likely not obvious to many other developers and users.
> And still no any valuable cons
Generally speaking, the project prefers stability and continuity as that
typically mitigates risk for our users - something which is greatly valued.
Therefore, anybody who is proposing a change must make an understandable case
for _why_ the change should be accepted.
> Aren't listed pros enough?
At this point the pros you've listed are not enough.
Issue Time Tracking
-------------------
Worklog Id: (was: 878243)
Time Spent: 4h 10m (was: 4h)
> Explicit logger implementation instantiation
> --------------------------------------------
>
> Key: ARTEMIS-4393
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4393
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.30.0
> Reporter: Alexey Markevich
> Priority: Minor
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> - compilation error instead of runtime exception in case of logger annotation
> processor issue;
> - get rid of java.lang.reflect.* & java.security.* usage for logger case
> - hide logger implementation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
