[
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=878428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878428
]
ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/23 15:17
Start Date: 25/Aug/23 15:17
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4584:
URL:
https://github.com/apache/activemq-artemis/pull/4584#issuecomment-1693527991
> > So I guess its just a case of deciding whether we want to retain the
guava-style inline execution behaviour, or change to the Caffeine async
execution default.
>
> Regarding the cache usage in
`org.apache.activemq.artemis.core.security.impl.SecurityStoreImpl` my thoughts
are:
>
> 1. The only use-case where it really matters is with size = 0 and
that's been fixed that already via [ARTEMIS-4399 fix disabled authn/z cache
#4589](https://github.com/apache/activemq-artemis/pull/4589).
>
> 2. It makes sense to optimize security since it is used basically
every time a client connects.
>
>
> Therefore, I'm in favor of using the default from Caffeine.
Fair enough, since the SecurityStoreImpl doesnt look to use any of the
listener stuff so it probably isn't really much/any different. The other usage
does use it though, so I want to look into whether its prepared to handle the
new concurrency that could result from offloading to the FJ pool (though if
not, it may also not be prepared to handle any existing concurrency that could
occur already.)
Issue Time Tracking
-------------------
Worklog Id: (was: 878428)
Time Spent: 10h (was: 9h 50m)
> Replace Guava cache with Caffeine
> ---------------------------------
>
> Key: ARTEMIS-4349
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.29.0
> Reporter: Alexey Markevich
> Priority: Major
> Time Spent: 10h
> Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
