[
https://issues.apache.org/jira/browse/ARTEMIS-4401?focusedWorklogId=879719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-879719
]
ASF GitHub Bot logged work on ARTEMIS-4401:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/23 12:08
Start Date: 11/Sep/23 12:08
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4591:
URL: https://github.com/apache/activemq-artemis/pull/4591#discussion_r1321303257
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/util/ServerUtil.java:
##########
@@ -32,6 +32,7 @@
/**
* A tool to let clients start, stop and kill Artemis servers
+ * this class is Deprecated: use the one from artemis-test-support
Review Comment:
Its not actually marked as deprecated though? If its considered so it should
probably be, or else its more likely people could use the wrong one given the
identical class name? Should add a full stop on first line and capitalise T in
"this" to make the javadoc read better.
Edit: Ah, perhaps as its used in various examples, which cant use the
artemis-test-support one? In which case, is there actually real benefit to
duplicating this class currently?
##########
docs/user-manual/paging.adoc:
##########
@@ -123,6 +123,11 @@ This tells what to do if the system is reaching
`page-limit-bytes` or `page-limi
|
|===
+
+[NOTE]
+
+When using the JDBC storage, page-size-bytes is maxed out by
jdbc-max-page-size from the JDBC Storage configuration
Review Comment:
"page-size-bytes is maxed out by" -> "the effective page-size-bytes used is
limited to a maximum of" ?
##########
tests/db-tests/pom.xml:
##########
@@ -0,0 +1,469 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.activemq.tests</groupId>
+ <artifactId>artemis-tests-pom</artifactId>
+ <version>2.31.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>db-tests</artifactId>
+ <packaging>jar</packaging>
+ <name>Database Tests</name>
+
+ <properties>
+ <activemq.basedir>${project.basedir}/../../</activemq.basedir>
+ <!
Issue Time Tracking
-------------------
Worklog Id: (was: 879719)
Time Spent: 1h 20m (was: 1h 10m)
> slow performance of JDBC while paging
> -------------------------------------
>
> Key: ARTEMIS-4401
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4401
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Syncs are not properly implemented into page files. Basically ever message
> sent and every blob update is issuing a sync update on the context and a
> commit on the Database.
> Certain databases will have an OK performance with lots of commits (e.g.
> Postgres) but I'm not sure how correct is the blob update.
> As part of this task I'm creating a few Database tests to validate these
> changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
