[
https://issues.apache.org/jira/browse/ARTEMIS-4436?focusedWorklogId=882343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882343
]
ASF GitHub Bot logged work on ARTEMIS-4436:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/23 09:05
Start Date: 28/Sep/23 09:05
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4628:
URL: https://github.com/apache/activemq-artemis/pull/4628#discussion_r1339785211
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java:
##########
@@ -554,10 +554,12 @@ public boolean updateMember(long uniqueEventID, String
nodeId, TopologyMemberImp
* @return
*/
@Override
- public boolean removeMember(final long uniqueEventID, final String nodeId) {
+ public boolean removeMember(final long uniqueEventID, final String nodeId,
final boolean disconnect) {
if (nodeId.equals(nodeManager.getNodeId().toString())) {
- ActiveMQServerLogger.LOGGER.possibleSplitBrain(nodeId);
- return false;
+ if (!disconnect) {
+ ActiveMQServerLogger.LOGGER.possibleSplitBrain(nodeId);
+ return false;
+ }
Review Comment:
With my other comment about the 'info message if disconnect' you added
previously, I was meaning more to leave it always logging the warning, wheres
now this is back to not saying anything.
Unless we know for sure there isnt such possibility because it was a
shutdown? Its not clear to me, I dont know enough about the clustering to say
either way.
This also seems to change it from 'rejecting a topology update' to accepting
it in this case, which seems a larger change than just the logging, and which
I'm similarly not clear on the effect of. Need others with more knowledge
here...@clebertsuconic @jbertram ?
Issue Time Tracking
-------------------
Worklog Id: (was: 882343)
Time Spent: 2h (was: 1h 50m)
> Artemis is logging warnings during clean shutdown of server in cluster
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-4436
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4436
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.30.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> If a node from a cluster shutdowns cleanly this shouldn't create WARN
> messages in the logs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
