[ 
https://issues.apache.org/jira/browse/ARTEMIS-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nandor Soma Abonyi updated ARTEMIS-4449:
----------------------------------------
    Description: 
When simply `&` is used in the xml configuration according to the 
[documentation|#configuring-netty-ssl], `org.xml.sax.SAXParseException` will 
occur. Instead `&` or simply `;` should be used. I prefer the latter as the 
default configuration uses that character anyway.

Tldr. In case of
{code:java}
<acceptor 
name="netty">tcp://localhost:61617?sslEnabled=true&keyStorePath=/path</acceptor>
 {code}
this error is raised:
{code:java}
Fatal Error] :182:83: The reference to entity "keyStorePath" must end with the 
';' delimiter.
org.xml.sax.SAXParseException; lineNumber: 182; columnNumber: 83; The reference 
to entity "keyStorePath" must end with the ';' delimiter.
        at 
java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
        at 
java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
        at 
org.apache.activemq.artemis.utils.XMLUtil.readerToElement(XMLUtil.java:91)
        at 
org.apache.activemq.artemis.utils.XMLUtil.streamToElement(XMLUtil.java:64)
        at 
org.apache.activemq.artemis.utils.XMLUtil.urlToElement(XMLUtil.java:73)
        at 
org.apache.activemq.artemis.core.config.FileDeploymentManager.readConfiguration(FileDeploymentManager.java:71)
        at 
org.apache.activemq.artemis.integration.FileBroker.createComponents(FileBroker.java:120)
        at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:119)
        at 
org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:214)
        at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:164)
        at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:144)
        at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61) {code}

  was:
When simply `&` is used in the xml configuration according to the 
[documentation|#configuring-netty-ssl]], `org.xml.sax.SAXParseException` will 
occur. Instead `&` or simply `;` should be used. I prefer the latter as the 
default configuration uses that character anyway.

Tldr. In case of
{code:java}
<acceptor 
name="netty">tcp://localhost:61617?sslEnabled=true&keyStorePath=/path</acceptor>
 {code}
this error is raised:
{code:java}
Fatal Error] :182:83: The reference to entity "keyStorePath" must end with the 
';' delimiter.
org.xml.sax.SAXParseException; lineNumber: 182; columnNumber: 83; The reference 
to entity "keyStorePath" must end with the ';' delimiter.
        at 
java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
        at 
java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
        at 
org.apache.activemq.artemis.utils.XMLUtil.readerToElement(XMLUtil.java:91)
        at 
org.apache.activemq.artemis.utils.XMLUtil.streamToElement(XMLUtil.java:64)
        at 
org.apache.activemq.artemis.utils.XMLUtil.urlToElement(XMLUtil.java:73)
        at 
org.apache.activemq.artemis.core.config.FileDeploymentManager.readConfiguration(FileDeploymentManager.java:71)
        at 
org.apache.activemq.artemis.integration.FileBroker.createComponents(FileBroker.java:120)
        at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:119)
        at 
org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:214)
        at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:164)
        at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:144)
        at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61) {code}


> [DOC] Fix url parameter separator in acceptor configuration
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-4449
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4449
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Nandor Soma Abonyi
>            Priority: Minor
>
> When simply `&` is used in the xml configuration according to the 
> [documentation|#configuring-netty-ssl], `org.xml.sax.SAXParseException` will 
> occur. Instead `&` or simply `;` should be used. I prefer the latter as the 
> default configuration uses that character anyway.
> Tldr. In case of
> {code:java}
> <acceptor 
> name="netty">tcp://localhost:61617?sslEnabled=true&keyStorePath=/path</acceptor>
>  {code}
> this error is raised:
> {code:java}
> Fatal Error] :182:83: The reference to entity "keyStorePath" must end with 
> the ';' delimiter.
> org.xml.sax.SAXParseException; lineNumber: 182; columnNumber: 83; The 
> reference to entity "keyStorePath" must end with the ';' delimiter.
>         at 
> java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
>         at 
> java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
>         at 
> org.apache.activemq.artemis.utils.XMLUtil.readerToElement(XMLUtil.java:91)
>         at 
> org.apache.activemq.artemis.utils.XMLUtil.streamToElement(XMLUtil.java:64)
>         at 
> org.apache.activemq.artemis.utils.XMLUtil.urlToElement(XMLUtil.java:73)
>         at 
> org.apache.activemq.artemis.core.config.FileDeploymentManager.readConfiguration(FileDeploymentManager.java:71)
>         at 
> org.apache.activemq.artemis.integration.FileBroker.createComponents(FileBroker.java:120)
>         at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:119)
>         at 
> org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:214)
>         at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:164)
>         at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>         at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>         at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:144)
>         at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61) 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to