[
https://issues.apache.org/jira/browse/ARTEMIS-4477?focusedWorklogId=887488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887488
]
ASF GitHub Bot logged work on ARTEMIS-4477:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/23 23:55
Start Date: 26/Oct/23 23:55
Worklog Time Spent: 10m
Work Description: gastaldi commented on PR #4657:
URL:
https://github.com/apache/activemq-artemis/pull/4657#issuecomment-1782086997
Just saw that the Johnzon provider is instantiated directly in
https://github.com/apache/activemq-artemis/blob/main/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/JsonLoader.java#L38,
so the META-INF/services is useless.
I'll recommend merging #4658 instead.
Issue Time Tracking
-------------------
Worklog Id: (was: 887488)
Time Spent: 1h 20m (was: 1h 10m)
> artemis-commons does not transform the
> META-INF/services/javax.json.spi.JsonProvider to the shaded package
> ----------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-4477
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4477
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.31.1
> Reporter: George Gastaldi
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Johnzon is shaded in artemis-common but the
> {{META-INF/services/javax.json.spi.JsonProvider}} included in the
> artemis-commons JAR points to the original class, not the shaded one, causing
> the following error when used as a dependency:
> {code:java}
> Caused by: java.util.ServiceConfigurationError: javax.json.spi.JsonProvider:
> Provider org.apache.johnzon.core.JsonProviderImpl not found
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:589)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1212)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
> at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
> at javax.json.spi.JsonProvider.provider(JsonProvider.java:68)
> at
> io.smallrye.health.SmallRyeHealthReporter.<init>(SmallRyeHealthReporter.java:126)
> at io.smallrye.health.SmallRyeHealthReporter_ClientProxy.<init>(Unknown
> Source)
> at io.smallrye.health.SmallRyeHealthReporter_Bean.proxy(Unknown Source)
> at io.smallrye.health.SmallRyeHealthReporter_Bean.get(Unknown Source)
> at io.smallrye.health.SmallRyeHealthReporter_Bean.get(Unknown Source)
> at io.quarkus.arc.impl.InstanceImpl.getBeanInstance(InstanceImpl.java:229)
> at io.quarkus.arc.impl.InstanceImpl.getInternal(InstanceImpl.java:215)
> at io.quarkus.arc.impl.InstanceImpl.get(InstanceImpl.java:100)
> at
> io.quarkus.smallrye.health.runtime.SmallRyeHealthRecorder.processSmallRyeHealthRuntimeConfiguration(SmallRyeHealthRecorder.java:47)
> at
> io.quarkus.deployment.steps.SmallRyeHealthProcessor$processSmallRyeHealthRuntimeConfig1687788508.deploy_0(Unknown
> Source)
> at
> io.quarkus.deployment.steps.SmallRyeHealthProcessor$processSmallRyeHealthRuntimeConfig1687788508.deploy(Unknown
> Source)
> ... 53 more
> {code}
> This bug seems to have been introduced in
> [https://github.com/apache/activemq-artemis/commit/3392d084a904f9517a30242facb0159cf94fbc87]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
