[ 
https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894084
 ]

ASF GitHub Bot logged work on ARTEMIS-4498:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Dec/23 15:00
            Start Date: 05/Dec/23 15:00
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4702:
URL: https://github.com/apache/activemq-artemis/pull/4702#discussion_r1415763793


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1881,7 +1904,8 @@ public int getEncodeSize() {
          BufferHelper.sizeOfNullableInteger(idCacheSize) +
          BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null 
? pageFullMessagePolicy.toString() : null) +
          BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
-         BufferHelper.sizeOfNullableInteger(prefetchPageMessages);

Review Comment:
   why? I added a new record for AddressSettings, right?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 894084)
    Time Spent: 3h 20m  (was: 3h 10m)

> Enable management for internal addresses & queues
> -------------------------------------------------
>
>                 Key: ARTEMIS-4498
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4498
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Anton Roskvist
>            Priority: Major
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Originally "internal" addresses and queues weren't meant to be exposed via 
> management. However, due to a bug where the "internal" attribute of a queue 
> was not persisted properly such queues have been exposed to management for a 
> long time. This was fixed via ARTEMIS-4396, but users still want the ability 
> to manage internal queues because it is extremely helpful when trying to 
> troubleshoot issues. Therefore, this functionality should be configurable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to