[ 
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=899011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899011
 ]

ASF GitHub Bot logged work on ARTEMIS-4554:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/24 15:18
            Start Date: 10/Jan/24 15:18
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1447529539


##########
artemis-docker/prepare-docker.sh:
##########
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker 
image:
   # Go to $ARTEMIS_DIST_DIR
   $ cd $ARTEMIS_DIST_DIR
 
-  # For CentOS with full JDK 11
-  $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+  # For CentOS with full JDK 17
+  $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
 
-  # For Ubuntu with full JDK 11
-  $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+  # For Ubuntu with full JDK 21
+  $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
 
-  # For Ubuntu with just JRE 11
-  $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+  # For Ubuntu with just JRE 21
+  $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
 
-  # For Alpine with full JDK 17
-  $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+  # For Alpine with full JDK 21
+  $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
 
-  # For Alpine with just JRE 11
-  $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+  # For Alpine with just JRE 21
+  $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
 
-  # For Ubuntu on Linux ARMv7/ARM64 with full JDK
-  $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t 
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f 
./docker/Dockerfile-ubuntu-11 .
+  # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+  $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t 
{your-repository}/apache-artemis:{your-version} -f 
./docker/Dockerfile-ubuntu-21 .

Review Comment:
   Simplifying to `linux/arm64` sounds good to me.
   
   I actually ran into the issue you linked where the image I built with 
`linux/arm64/v8` reported just `linux/arm64` when I looked at it on Docker Hub. 
I was confused at first, but now it makes more sense.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 899011)
    Time Spent: 1h 50m  (was: 1h 40m)

> Upgrade to latest Java for Docker images 
> -----------------------------------------
>
>                 Key: ARTEMIS-4554
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to