[ https://issues.apache.org/jira/browse/ARTEMIS-4651?focusedWorklogId=906461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906461 ]
ASF GitHub Bot logged work on ARTEMIS-4651: ------------------------------------------- Author: ASF GitHub Bot Created on: 22/Feb/24 14:32 Start Date: 22/Feb/24 14:32 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4827: URL: https://github.com/apache/activemq-artemis/pull/4827#discussion_r1499339024 ########## artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/collections/JournalHashMap.java: ########## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.activemq.artemis.core.journal.collections; + +import java.lang.invoke.MethodHandles; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import java.util.function.BiConsumer; +import java.util.function.LongFunction; +import java.util.function.LongSupplier; +import java.util.function.Supplier; + +import org.apache.activemq.artemis.core.io.IOCriticalErrorListener; +import org.apache.activemq.artemis.core.journal.IOCompletion; +import org.apache.activemq.artemis.core.journal.Journal; +import org.apache.activemq.artemis.core.persistence.Persister; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class JournalHashMap<K, V, C> implements Map<K, V> { + + private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + public static class MapRecord<K, V> implements Entry<K, V> { Review Comment: The value here is the MapRecord... it can have them called for collisions. Issue Time Tracking ------------------- Worklog Id: (was: 906461) Time Spent: 2h 10m (was: 2h) > Performance improvements on Mirror and Paging > --------------------------------------------- > > Key: ARTEMIS-4651 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4651 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Clebert Suconic > Assignee: Clebert Suconic > Priority: Major > Fix For: 2.33.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Before this change, sends were not paged at the SNF. They are now copied. > I also added a different scheme for retrying messages in a batches. A > collection with pending IDs is created and a few retries are performed at > different levels. -- This message was sent by Atlassian Jira (v8.20.10#820010)