[ https://issues.apache.org/jira/browse/ARTEMIS-4651?focusedWorklogId=906485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906485 ]
ASF GitHub Bot logged work on ARTEMIS-4651: ------------------------------------------- Author: ASF GitHub Bot Created on: 22/Feb/24 15:38 Start Date: 22/Feb/24 15:38 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4827: URL: https://github.com/apache/activemq-artemis/pull/4827#discussion_r1499447542 ########## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java: ########## @@ -424,6 +453,10 @@ public void preAcknowledge(final Transaction tx, final MessageReference ref, fin MirrorController controllerInUse = getControllerInUse(); + if (controllerInUse != null && !controllerInUse.isAllowACK()) { Review Comment: Ohh... I see now.. when you said "this comment" I thought you were referring to this: https://github.com/apache/activemq-artemis/blob/bc7e4639e0a4665c106f336fb837c33d2cbcd361/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java#L427 That log. was already there before, and I see it now.. I am changing it. and I also made an improvement to the code there as well. Issue Time Tracking ------------------- Worklog Id: (was: 906485) Time Spent: 4h (was: 3h 50m) > Performance improvements on Mirror and Paging > --------------------------------------------- > > Key: ARTEMIS-4651 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4651 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Clebert Suconic > Assignee: Clebert Suconic > Priority: Major > Fix For: 2.33.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Before this change, sends were not paged at the SNF. They are now copied. > I also added a different scheme for retrying messages in a batches. A > collection with pending IDs is created and a few retries are performed at > different levels. -- This message was sent by Atlassian Jira (v8.20.10#820010)