[ https://issues.apache.org/jira/browse/ARTEMIS-4582?focusedWorklogId=909200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909200 ]
ASF GitHub Bot logged work on ARTEMIS-4582: ------------------------------------------- Author: ASF GitHub Bot Created on: 11/Mar/24 13:17 Start Date: 11/Mar/24 13:17 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519702003 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/config/PersistedSecuritySetting.java: ########## @@ -77,7 +83,7 @@ public PersistedSecuritySetting(final String addressMatch, final String manageRoles, final String browseRoles, final String createAddressRoles, - final String deleteAddressRoles) { + final String deleteAddressRoles, String viewRoles, String updateRoles) { Review Comment: sure. Issue Time Tracking ------------------- Worklog Id: (was: 909200) Time Spent: 2h 40m (was: 2.5h) > add view and update permissions to augment the manage rbac for control > resources > -------------------------------------------------------------------------------- > > Key: ARTEMIS-4582 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4582 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker, Configuration, JMX, Web Console > Affects Versions: 2.31.0 > Reporter: Gary Tully > Assignee: Gary Tully > Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > we have the manage permission that allows sending to the management address, > to access any control resource. We don't however distinguish what a user can > do. > We should segment control operations into categories: CRUD provides a basis > view for get/is (Read) > update for set or operations that mutate or modify. > We allow this sort of configuration via management.xml for jmx mbean access > but using a different model based on object name. > All of the mbeans delegate to the control resources. > If we add these two additional permissions then we can have a single rbac > model (that supports config reload) and more granularity on control resource > access from the management address. -- This message was sent by Atlassian Jira (v8.20.10#820010)