[ 
https://issues.apache.org/jira/browse/AMQ-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841001#comment-17841001
 ] 

Matthew Washburn commented on AMQ-9483:
---------------------------------------

I attached another patch. I'm not sure if this is the correct way to get the 
daemon property in FailoverTransportFactory, but this is the correct thread 
pool to change to fix issue 796. That 
executor is only used to handle errors and so it might never get any work 
assigned to it so it never creates any threads. And even if it did, it 
specifies a time out of 5 seconds, so if you reconnect interval was greater 
than 5 it will still exit. 

> Non Daemon Connection Keeping JVM alive when combined with 
> optimizedAckScheduledAckInterval
> -------------------------------------------------------------------------------------------
>
>                 Key: AMQ-9483
>                 URL: https://issues.apache.org/jira/browse/AMQ-9483
>             Project: ActiveMQ Classic
>          Issue Type: Bug
>          Components: JMS client
>    Affects Versions: 5.18.4
>            Reporter: Matthew Washburn
>            Priority: Major
>         Attachments: 
> 0001-make-sure-the-executor-service-for-deliveryingAcknow.patch, 796.patch
>
>
> The thread used to send ack unacked messages when using the 
> optimizedAckScheduledAckInterval is not daemon even if the connection is set 
> to daemon. This is probably advantageous as you would not want a queue or 
> durable topic consumer to shutdown before it has finished acking a message 
> causing it to be redelivered on restart. On the other hand, it means that if 
> the optimized ack scheduler ever kicks in on a daemon connection the JVM will 
> never exit. Also the thread isn't uniquely named so it's hard to track down.
>  
> I'm not sure how to get in the situation where there are unacked messages 
> that are acked by the timer so I'm not sure how to create a simple repo 
> script but the attached patch fixes my application. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to