[ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921130
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/May/24 21:12
            Start Date: 28/May/24 21:12
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4944:
URL: https://github.com/apache/activemq-artemis/pull/4944#discussion_r1617897308


##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -4913,6 +4913,14 @@
                </xsd:annotation>
             </xsd:element>
 
+            <xsd:element name="security-caches" type="xsd:boolean" 
default="false" maxOccurs="1" minOccurs="0">

Review Comment:
   The instances of Caffeine caches which are related to security is what is 
being instrumented here. Metrics that are made available when this is set to 
`true` are things like:
   
   - `cache.size`
   - `cache.puts`
   - `cache.gets` tagged by `result` - either `hit` or `miss`
   - `cache.evictions`
   - `cache.eviction.weight`
   
   Therefore, calling it `security-caches` seems appropriate.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 921130)
    Time Spent: 0.5h  (was: 20m)

> Add authn/z metrics
> -------------------
>
>                 Key: ARTEMIS-4306
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to