[ https://issues.apache.org/jira/browse/ARTEMIS-4792?focusedWorklogId=921984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921984 ]
ASF GitHub Bot logged work on ARTEMIS-4792: ------------------------------------------- Author: ASF GitHub Bot Created on: 04/Jun/24 14:49 Start Date: 04/Jun/24 14:49 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4956: URL: https://github.com/apache/activemq-artemis/pull/4956#discussion_r1626157503 ########## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/DefaultSenderController.java: ########## @@ -440,7 +474,7 @@ public void close() throws Exception { } } else if (source != null && source.getDynamic() && (source.getExpiryPolicy() == TerminusExpiryPolicy.LINK_DETACH || source.getExpiryPolicy() == TerminusExpiryPolicy.SESSION_END)) { try { - sessionSPI.removeTemporaryQueue(SimpleString.toSimpleString(source.getAddress())); + sessionSPI.removeTemporaryQueue(SimpleString.toSimpleString(getSourceAddress(source))); Review Comment: Can this one use the new variable too? Issue Time Tracking ------------------- Worklog Id: (was: 921984) Time Spent: 0.5h (was: 20m) > Add support for setting consumer priority on AMQP Receiver Source addresses > --------------------------------------------------------------------------- > > Key: ARTEMIS-4792 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4792 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: AMQP > Affects Versions: 2.34.0 > Reporter: Timothy A. Bish > Assignee: Timothy A. Bish > Priority: Minor > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > When creating a receiver link from a client the only way currently to adjust > the consumer priority on the broker is to set a value in the receiver > properties to indicate the desired priority. For some client AMQP client > libraries this is not simple or not possible in the provided API. To solve > this we can add support for parsing URI type options from the source address > of the receiver attach and look for the option "consumer-priority" which is > also used by the Core client to configure consumer priority (Openwire clients > can do the same via an openwire client property "consumer.priority"). > This updates the client receiver attach to extract properties from the > address the source which have the form: > {code:java} > address?consumer-priority=1{code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact